On 04/04/2012 11:03 AM, Dan Magenheimer wrote: >> From: Seth Jennings [mailto:sjenning@xxxxxxxxxxxxxxxxxx] >> Sent: Monday, April 02, 2012 8:14 AM >> To: Greg Kroah-Hartman >> Cc: Nitin Gupta; Dan Magenheimer; Konrad Rzeszutek Wilk; Robert Jennings; Seth Jennings; >> devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx >> Subject: [PATCH] staging: zsmalloc: fix memory leak >> >> From: Nitin Gupta <ngupta@xxxxxxxxxx> >> >> This patch fixes a memory leak in zsmalloc where the first >> subpage of each zspage is leaked when the zspage is freed. >> >> Based on 3.4-rc1. >> >> Signed-off-by: Nitin Gupta <ngupta@xxxxxxxxxx> >> Acked-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx> > > This is a rather severe memory leak and will affect most > benchmarking anyone does to evaluate zcache in 3.4 (e.g. as > to whether zcache is suitable for promotion), so t'would be nice > to get this patch in for -rc2. (Note it fixes a "regression" > since it affects zcache only in 3.4+ because the fix is to > the new zsmalloc allocator... so no change to stable trees.) > > Acked-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> Thanks Dan for this clarification and the Ack. I should have tagged this as urgent for the 3.4 release and no impact on stable trees, since 3.4 is the first release with this code. -- Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>