Re: [PATCH v2 04/24] page_pool: Convert page_pool_release_page() to page_pool_release_netmem()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 10 Jan 2023 at 20:47, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 10, 2023 at 11:28:10AM +0200, Ilias Apalodimas wrote:
> > > -static inline void page_pool_release_page(struct page_pool *pool,
> > > -                                     struct page *page)
> > > +static inline void page_pool_release_netmem(struct page_pool *pool,
> > > +                                     struct netmem *nmem)
> > >  {
> > >  }
> > >
> > > @@ -378,6 +378,12 @@ static inline void page_pool_put_page_bulk(struct page_pool *pool, void **data,
> > >  }
> > >  #endif
> > >
> >
> > I think it's worth commenting here that page_pool_release_page() is
> > eventually going to be removed once we convert all drivers and shouldn't
> > be used anymore
>
> OK.  How about I add this to each function in this category:
>
> /* Compat, remove when all users gone */
>
> and then we can find them all by grepping for 'Compat'?

Yep that's fine

Thanks
/Ilias




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux