Hello Liam,
On Mon, 9 Jan 2023 20:30:50 +0000 Liam Howlett <liam.howlett@xxxxxxxxxx> wrote:
> * SeongJae Park <sj@xxxxxxxxxx> [230109 14:28]:
> > On Mon, 9 Jan 2023 16:45:46 +0000 Liam Howlett <liam.howlett@xxxxxxxxxx> wrote:
> >
> > > * SeongJae Park <sj@xxxxxxxxxx> [230106 21:40]:
> > > > Hello Liam,
> > > >
> > > > On Sat, 7 Jan 2023 02:01:26 +0000 SeongJae Park <sj@xxxxxxxxxx> wrote:
> > > >
> > > > > Hello Liam,
> > > > >
> > > > >
> > > > > I found 'make install' mm-unstable kernel fails from initramfs stage with
> > > > > 'not a dynamic executable' message. I confirmed the issue is not reproducible
> > > > > before your patchset[1] but after the series[2].
> > > > >
> > > > > I tried to bisect, but on a commit[3] middle of mm-unstable tree which this
> > > > > patch is applied, I get below error while booting. Do you have an idea?
> > > >
> > > > I further bisected for the boot failure. The first bad commit was a8e0f2e12936
> > > > ("mmap: change do_mas_munmap and do_mas_aligned_munmap() to use vma
> > > > iterator")[1]. The stacktrace on the commit is as below.
> > > >
> > > ...
> > >
> > > Thanks for your work on this.
> > >
> > > I have found the issue and will send out a fix shortly. I am not
> > > handling the invalidated state correctly in the write path.
> >
> > Thank you, I tested the patch and confirmed it is fixing the boot failure. The
> > 'make install' issue on my system is not fixed yet, though. While doing bisect
> > of the issue again with your boot failure fix, I found below build failure on a
> > commit applying a patch of this series, namely "userfaultfd: use vma iterator".
> >
> > mm/madvise.c: In function ‘madvise_update_vma’:
> > mm/madvise.c:165:11: error: implicit declaration of function ‘__split_vma’; did you mean ‘split_vma’? [-Werror=implicit-function-declaration]
> > 165 | error = __split_vma(mm, vma, start, 1);
> > | ^~~~~~~~~~~
> > | split_vma
> > cc1: some warnings being treated as errors
> >
> > Maybe "mm: add temporary vma iterator versions of vma_merge(), split_vma(), and
> > __split_vma()" caused the build failure?
>
> Yes, it seems I removed the external declaration before the function.
> Thanks.
I continued bisect with your fix for this[1], and found my 'make install' issue
comes from 'mm: change mprotect_fixup to vma iterator'.
[1] https://lore.kernel.org/linux-mm/20230109205300.955019-1-Liam.Howlett@xxxxxxxxxx/
Thanks,
SJ
