On Fri, 2023-01-06 at 09:29 -0800, Dave Hansen wrote: > The subject here is a bit too specific. This patch isn't just > "implementing functions". There are more than just functions here. The > best subject is probably: > > Add SEAMCALL infrastructure Yes this is better. Thanks. > > But that's rather generic by necessity because this patch does several > _different_ logical things: > > * Wrap TDX_MODULE_CALL so it can be used for SEAMCALLs with host=1 > * Add handling to TDX_MODULE_CALL to allow it to handle specifically > host-side error conditions > * Add high-level seamcall() function with actual error handling > > It's probably also worth noting that the code that allows "host=1" to be > passed to TDX_MODULE_CALL is dead code in mainline right now. It > probably shouldn't have been merged this way, but oh well. > > I don't know that you really _need_ to split this up, but I'm just > pointing out that mashing three different logical things together makes > it hard to write a coherent Subject. But, I've seen worse. Agreed. To me seems "Add SEAMCALL infrastructure" is good enough, but I can split up if you want me to.
