Re: [PATCHv3 06/12] dmapool: move debug code to own functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Keith Busch <kbusch@xxxxxxxx>
Subject: Re: [PATCHv3 06/12] dmapool: move debug code to own functions
From: Christoph Hellwig <hch@xxxxxx>
Date: Sun, 8 Jan 2023 18:06:48 +0100
Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Tony Battersby <tonyb@xxxxxxxxxxxxxxx>, Kernel Team <kernel-team@xxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>
In-reply-to: <20230103191551.3254778-7-kbusch@meta.com>
References: <20230103191551.3254778-1-kbusch@meta.com> <20230103191551.3254778-7-kbusch@meta.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> +#ifdef	DMAPOOL_DEBUG

I'd drop the weird tab indent carrier over from the original code here.

Also any reason to not use a single big ifdef blocked instead of
multiple ones?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCHv3 00/12] dmapool enhancements
  - From: Keith Busch
- [PATCHv3 06/12] dmapool: move debug code to own functions
  - From: Keith Busch

Prev by Date: [PATCH 7/7] mm,jfs: move write_one_page/folio_write_one to jfs
Next by Date: Re: [PATCHv3 08/12] dmapool: consolidate page initialization
Previous by thread: [PATCHv3 06/12] dmapool: move debug code to own functions
Next by thread: [PATCH mm-unstable 0/9] continue hugetlb folio conversions
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux