Re: [PATCH v13 3/6] mm/vmstat: manage per-CPU stats from CPU context when NOHZ full

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6 Jan 2023 09:51:00 -0300 Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> On Fri, Jan 06, 2023 at 08:12:44AM +0800, Hillf Danton wrote:
> > 
> > Regression wrt V12 if timer is added on the CPU that is not doing HK_TYPE_TIMER?
> 
> Before this change, the timer was managed (and queued on an isolated
> CPU) by vmstat_shepherd. Now it is managed (and queued) by the local
> CPU, so there is no regression.

Given vm stats folded when returning to userspace, queuing the delayed work
barely makes sense in the first place. If it can be canceled, queuing it burns
cycles with nothing earned. Otherwise vm stats got folded already.

Nor does shepherd even without delay. And the right thing is only make shepherd
leave isolated CPUs intact.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux