On mercoledì 4 gennaio 2023 15:40:26 CET Matthew Wilcox wrote: > On Wed, Jan 04, 2023 at 01:18:45PM +0100, Fabio M. De Francesco wrote: > > In the kdocs of kmap_local_folio() there is a an ambiguous sentence > > which suggests to use this API "only when really necessary". > > Looks like you removed it from kmap_local_page() docs in 72f1c55adf70 > after I copied it in 53c36de0701f. That information should probably > also be in this changelog. > Matthew, I just added that information in v2 (I didn't know that I should have better added it - thanks for letting me know about this practice): https://lore.kernel.org/lkml/20230105120424.30055-1-fmdefrancesco@xxxxxxxxx/ > > > * While it is significantly faster than kmap() for the higmem case it > > Also, s/higmem/highmem/ (both in the kmap_local_page() and > kmap_local_folio() docs) > Since these spelling mistakes are un-related to the purpose of the deletion, I fixed them in a separate patch: https://lore.kernel.org/lkml/20230105121305.30714-1-fmdefrancesco@xxxxxxxxx/ Again thanks for commenting my patch and suggesting improvements. Fabio
