>From bcrl@xxxxxxxxx Fri Mar 30 06:00:02 2012
Return-Path: <bcrl@xxxxxxxxx>
X-Original-To: int-list-linux-mm@xxxxxxxxx
Delivered-To: int-list-linux-mm@xxxxxxxxx
Received: by kanga.kvack.org (Postfix, from userid 63042)
id 71D416B007E; Fri, 30 Mar 2012 06:00:02 -0400 (EDT)
X-Original-To: linux-mm@xxxxxxxxx
Delivered-To: linux-mm@xxxxxxxxx
Received: from psmtp.com (na3sys010amx139.postini.com [74.125.245.139])
by kanga.kvack.org (Postfix) with SMTP id BCB776B004A
for <linux-mm@xxxxxxxxx>; Fri, 30 Mar 2012 06:00:01 -0400 (EDT)
Received: from metis.ext.pengutronix.de ([92.198.50.35]) (using TLSv1) by na3sys010amx139.postini.com ([74.125.244.10]) with SMTP;
Fri, 30 Mar 2012 10:00:01 GMT
Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c])
by metis.ext.pengutronix.de with esmtp (Exim 4.72)
(envelope-from <ukl@xxxxxxxxxxxxxx>)
id 1SDYc7-0004Tg-IU; Fri, 30 Mar 2012 11:59:23 +0200
Received: from ukl by dude.hi.pengutronix.de with local (Exim 4.77)
(envelope-from <ukl@xxxxxxxxxxxxxx>)
id 1SDYbk-0004Z4-0y; Fri, 30 Mar 2012 11:59:00 +0200
Date: Fri, 30 Mar 2012 11:59:00 +0200
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
To: linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>,
Anatolij Gustschin <agust@xxxxxxx>,
Andreas Koensgen <ajk@xxxxxxxxxxxxxxxxxxxxx>,
Andrew Lunn <andrew@xxxxxxx>, Andrew Victor <linux@xxxxxxxxxxxx>,
Arnd Bergmann <arnd@xxxxxxxx>, Barry Song <baohua.song@xxxxxxx>,
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>,
Bryan Huntsman <bryanh@xxxxxxxxxxxxxx>,
cbe-oss-dev@xxxxxxxxxxxxxxxx,
Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>,
Daniel Walker <dwalker@xxxxxxxxxx>,
David Brown <davidb@xxxxxxxxxxxxxx>,
David Howells <dhowells@xxxxxxxxxx>,
"David S. Miller" <davem@xxxxxxxxxxxxx>,
David Woodhouse <dwmw2@xxxxxxxxxxxxx>,
davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx,
Eric Miao <eric.y.miao@xxxxxxxxx>,
Fenghua Yu <fenghua.yu@xxxxxxxxx>,
Grant Likely <grant.likely@xxxxxxxxxxxx>,
Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>,
Haojian Zhuang <haojian.zhuang@xxxxxxxxx>,
Henrique de Moraes Holschuh <ibm-acpi@xxxxxxxxxx>,
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx,
Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>,
Jean Delvare <khali@xxxxxxxxxxxx>,
Jean-Paul Roubelat <jpr@xxxxxxxxx>, Joerg Reuter <jreuter@xxxxxxxx>,
Josh Boyer <jwboyer@xxxxxxxxx>, Kevin Hilman <khilman@xxxxxx>,
Klaus Kudielka <klaus.kudielka@xxxxxxxx>,
Kukjin Kim <kgene.kim@xxxxxxxxxxx>,
Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>,
Kyungmin Park <kyungmin.park@xxxxxxxxxxx>,
Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>,
Linus Walleij <linus.walleij@xxxxxxxxxx>,
Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>,
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx,
linux-hams@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx,
linux-ide@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx,
linux-mips@xxxxxxxxxxxxxx, linux-mm@xxxxxxxxx,
linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx,
linuxppc-dev@xxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx,
lm-sensors@xxxxxxxxxxxxxx,
Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>,
Matthew Garrett <mjg59@xxxxxxxxxxxxx>,
Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>,
Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>,
netdev@xxxxxxxxxxxxxxx, Nicolas Ferre <nicolas.ferre@xxxxxxxxx>,
Nicolas Pitre <nico@xxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>,
platform-driver-x86@xxxxxxxxxxxxxxx,
Ralf Baechle <ralf@xxxxxxxxxxxxxx>,
Randy Dunlap <rdunlap@xxxxxxxxxxxx>,
Russell King <linux@xxxxxxxxxxxxxxxx>,
Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>,
Sascha Hauer <kernel@xxxxxxxxxxxxxx>, Sekhar Nori <nsekhar@xxxxxx>,
Shawn Guo <shawn.guo@xxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>,
Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx>,
Tony Lindgren <tony@xxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>,
Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 00/17] mark const init data with __initconst instead of
__initdata
Message-ID: <20120330095859.GT15647@xxxxxxxxxxxxxx>
References: <20120329211131.GA31250@xxxxxxxxxxxxxx>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20120329211131.GA31250@xxxxxxxxxxxxxx>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c
X-SA-Exim-Mail-From: ukl@xxxxxxxxxxxxxx
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-mm@xxxxxxxxx
X-pstn-neptune: 1/1/1.00/100
X-pstn-levels: (S:99.90000/99.90000 CV:99.9000 FC:95.5390 LC:95.5390 R:95.9108 P:95.9108 M:97.0282 C:98.6951 )
X-pstn-dkim: 0 skipped:not-enabled
X-pstn-settings: 3 (1.0000:1.0000) s cv gt3 gt2 gt1 r p m c
X-pstn-addresses: from <u.kleine-koenig@xxxxxxxxxxxxxx> [db-null]
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.2
On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-K�nig wrote:
> Hello,
>
> this series fixes a common error to use __initdata to mark const
> variables. Most of the time this works well enough to go unnoticed
> (though I wonder why the linker doesn't warn about that).
> Just try adding something like
>
> int something __initdata;
>
> to one of the patched files and compile to see the error.
>
> While touching these annotations I also corrected the position where it
> was wrong to go between the variable name and the =.
>
> Note this series is not compile tested.
After a question by Shawn Guo I noticed that my command to do the changes
was to lax and changed things that must not be changed (at least not
with further care). Affected are lines like:
static const char *at91_dt_board_compat[] __initconst = {
While at91_dt_board_compat[0] is const, at91_dt_board_compat is not.
I will send a fixed series later today.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K�nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>