Re: [PATCH] mm: huge_memory: convert split_huge_pages_all() to use a folio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2022/12/30 16:14, Matthew Wilcox wrote:
On Thu, Dec 29, 2022 at 08:25:03PM +0800, Kefeng Wang wrote:
-			if (!PageHead(page) || PageHuge(page) || !PageLRU(page))
+			if (!folio_test_large(folio)
+				|| folio_test_hugetlb(folio)
+				|| !folio_test_lru(folio))
  				goto next;

That is a completely illegible way of indenting this code!  There's
no visual cue when the condition stops and when the next statement
begins.  Try one of these:

sorry about the bad indenting,
			if (!folio_test_large(folio) ||
			    folio_test_hugetlb(folio) ||
			    !folio_test_lru(folio))
				goto next;

will resend with this one, thanks for your review.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux