> + size += sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", > + pool->name, blocks, > + pages * (pool->allocation / pool->size), > + pool->size, pages); Did I mention that the sysfs_emit_at API sucks and should just take size as a pointer argument an auto-increment? Not really something we can change in this series, though. So: Reviewed-by: Christoph Hellwig <hch@xxxxxx>