On Wed, Dec 21, 2022 at 11:13 PM Yuanchu Xie <yuanchu@xxxxxxxxxx> wrote: > > From: Yu Zhao <yuzhao@xxxxxxxxxx> > > Currently in vm_flags in vm_area_struct, both VM_SEQ_READ and > VM_RAND_READ indicate a lack of locality in accesses to the vma. Some > places that check for locality are missing one of them. We add > vma_has_locality to replace the existing locality checks for clarity. Need benchmark results. A simple fio test will do; doesn't need to be the curl one. > + /* > + * If we are reclaiming on behalf of a cgroup, skip counting on behalf > + * of references from different cgroups Nit: add a period at the end. > @@ -906,6 +908,7 @@ int folio_referenced(struct folio *folio, int is_locked, > .arg = (void *)&pra, > .anon_lock = folio_lock_anon_vma_read, > .try_lock = true, > + .invalid_vma = invalid_folio_referenced_vma, Nice. (What I suggested isn't as clean: https://lore.kernel.org/all/Y31s%2FK8T85jh05wH@xxxxxxxxxx/)
