Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Huang, Kai" <kai.huang@xxxxxxxxx>
Subject: Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes
From: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
Date: Mon, 19 Dec 2022 15:54:32 +0800
Cc: "linux-api@xxxxxxxxxxxxxxx" <linux-api@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "jmattson@xxxxxxxxxx" <jmattson@xxxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "ak@xxxxxxxxxxxxxxx" <ak@xxxxxxxxxxxxxxx>, "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>, "david@xxxxxxxxxx" <david@xxxxxxxxxx>, "tabba@xxxxxxxxxx" <tabba@xxxxxxxxxx>, "Hocko, Michal" <mhocko@xxxxxxxx>, "michael.roth@xxxxxxx" <michael.roth@xxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "bfields@xxxxxxxxxxxx" <bfields@xxxxxxxxxxxx>, "dhildenb@xxxxxxxxxx" <dhildenb@xxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "vannapurve@xxxxxxxxxx" <vannapurve@xxxxxxxxxx>, "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>, "shuah@xxxxxxxxxx" <shuah@xxxxxxxxxx>, "vkuznets@xxxxxxxxxx" <vkuznets@xxxxxxxxxx>, "vbabka@xxxxxxx" <vbabka@xxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "mail@xxxxxxxxxxxxxxxxxxxxx" <mail@xxxxxxxxxxxxxxxxxxxxx>, "qperret@xxxxxxxxxx" <qperret@xxxxxxxxxx>, "Christopherson,, Sean" <seanjc@xxxxxxxxxx>, "ddutile@xxxxxxxxxx" <ddutile@xxxxxxxxxx>, "naoya.horiguchi@xxxxxxx" <naoya.horiguchi@xxxxxxx>, "aarcange@xxxxxxxxxx" <aarcange@xxxxxxxxxx>, "wanpengli@xxxxxxxxxxx" <wanpengli@xxxxxxxxxxx>, "yu.c.zhang@xxxxxxxxxxxxxxx" <yu.c.zhang@xxxxxxxxxxxxxxx>, "hughd@xxxxxxxxxx" <hughd@xxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "jlayton@xxxxxxxxxx" <jlayton@xxxxxxxxxx>, "joro@xxxxxxxxxx" <joro@xxxxxxxxxx>, "steven.price@xxxxxxx" <steven.price@xxxxxxx>, "Hansen, Dave" <dave.hansen@xxxxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "linmiaohe@xxxxxxxxxx" <linmiaohe@xxxxxxxxxx>, "Wang, Wei W" <wei.w.wang@xxxxxxxxx>
In-reply-to: <0889bab999cbb464e63490bdb5b3c68c07791979.camel@intel.com>
References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-7-chao.p.peng@linux.intel.com> <0889bab999cbb464e63490bdb5b3c68c07791979.camel@intel.com>
Reply-to: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>

On Tue, Dec 13, 2022 at 11:51:25PM +0000, Huang, Kai wrote:
> On Fri, 2022-12-02 at 14:13 +0800, Chao Peng wrote:
> >  
> > -	/* flags is currently not used. */
> > +	/* 'flags' is currently not used. */
> >  	if (attrs->flags)
> >  		return -EINVAL;
> 
> Unintended code change.

Yeah!

Chao

References:
- [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM
  - From: Chao Peng
- [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes
  - From: Chao Peng
- Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes
  - From: Huang, Kai

Prev by Date: Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory
Next by Date: Re: [PATCH v2 2/7] mm/vmalloc.c: add flags to mark vm_map_ram area
Previous by thread: Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes
Next by thread: Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]