On Tue, Dec 6, 2022 at 4:56 PM SeongJae Park <sj@xxxxxxxxxx> wrote: > > Hi Vishal, > > > Thank you for this patch. > > Nit pick. Could we please replace 'damon:' on the subject with 'mm/damon:' to > look more consistent with other DAMON patches? Thanks for looking over this patch! I'll make the subject mm/damon in a v2. > On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" <vishal.moola@xxxxxxxxx> wrote: > > > This change replaces 2 calls to compound_head() with one. > > I guess you mean _compound_head() calls in page_folio() that called from > mark_page_accessed() and folio_mark_accessed(). However, deactivate_page() > calls page_folio() anyway, so this patch doesn't reduce the number of calls to > one but keep the number, correct? Am I missing something? If I'm not, I'd > like to clean up the wording. The 2 calls I was referring to were from mark_page_accessed() and put_page(). As you've noticed, deactivate_page() still calls page_folio() here :). > > This is in preparation for the conversion of deactivate_page() to > > deactivate_folio(). > > I think folio_deactivate() might be a more consistent naming. What do you > think? I do like the name folio_deactivate() better than deactivate_folio(), I'll change that in v2 as well.
