Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Baoquan He <bhe@xxxxxxxxxx>
Subject: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc
From: Christoph Lameter <cl@xxxxxxxxx>
Date: Sun, 4 Dec 2022 17:21:44 +0100 (CET)
Cc: Wupeng Ma <mawupeng1@xxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, tj@xxxxxxxxxx, dennis@xxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Y4yOMmnrT772wFSL@MiWiFi-R3L-srv>
References: <20221204031430.662169-1-mawupeng1@huawei.com> <Y4yOMmnrT772wFSL@MiWiFi-R3L-srv>

On Sun, 4 Dec 2022, Baoquan He wrote:

> Can we change the conditional checking in fail part as below?

Yes please. This is potentially a rare condition that should get some
visibility.

References:
- [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc
  - From: Wupeng Ma
- Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc
  - From: Baoquan He

Prev by Date: [PATCH 3/3] mm: add __rcu symbol for task->mempolicy
Next by Date: Re: [PATCH 0/3] mm: replace atomic_t with percpu_ref in mempolicy.
Previous by thread: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc
Next by thread: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu_alloc
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux