On Sat, 2012-03-24 at 14:31 +0400, Anton Vorontsov wrote: > This is needed so that callers would not get 'context imbalance' > warnings from the sparse tool. > > As a side effect, this patch fixes the following sparse warnings: > > CHECK mm/oom_kill.c > mm/oom_kill.c:201:28: warning: context imbalance in 'oom_badness' - > unexpected unlock > include/linux/rcupdate.h:249:30: warning: context imbalance in > 'dump_tasks' - unexpected unlock > mm/oom_kill.c:453:9: warning: context imbalance in 'oom_kill_task' - > unexpected unlock > CHECK mm/memcontrol.c > ... > mm/memcontrol.c:1130:17: warning: context imbalance in > 'task_in_mem_cgroup' - unexpected unlock > > p.s. I know Peter Zijlstra detest the __cond_lock() stuff, but untill > we have anything better in sparse, let's use it. This particular > patch helped me to detect one bug that I myself made during > task->mm fixup series. So, it is useful. Yeah, so Nacked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> Also, why didn't lockdep catch it? Fix sparse already instead of smearing ugly all over. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href