On Tue, Nov 22, 2022 at 05:44:44PM -0700, Yu Zhao wrote: > Hi Johannes, > > Do you think it makes sense to have the below for both the baseline and > MGLRU or it's some behavior change that the baseline doesn't want to > risk? It looks good to me. Besides the new FMODE_NOREUSE, it's also a nice cleanup on the rmap side! It would just be good to keep the comment from folio_referenced_one() and move it to the vma_has_locality() check in invalid_folio_referenced_vma(). Otherwise, Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>