On (22/11/18 16:15), Nhat Pham wrote: > There is a lot of provision for flexibility that isn't actually needed > or used. Zswap (the only zpool user) always passes zpool_ops with an > .evict method set. The backends who reclaim only do so for zswap, so > they can also directly call zpool_ops without indirection or checks. > > Finally, there is no need to check the retries parameters and bail > with -EINVAL in the reclaim function, when that's called just a few > lines below with a hard-coded 8. There is no need to duplicate the > evictable and sleep_mapped attrs from the driver in zpool_ops. > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > Signed-off-by: Nhat Pham <nphamcs@xxxxxxxxx> Reviewed-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
