Re: [PATCH 00/16] mm: prepare for converting vm->vm_flags to 64-bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 22, 2012 at 02:41:22PM -0700, Andrew Morton wrote:
> On Thu, 22 Mar 2012 21:28:11 +0000
> Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Thu, Mar 22, 2012 at 02:26:47PM -0700, Andrew Morton wrote:
> > > It would be nice to find some way of triggering compiler warnings or
> > > sparse warnings if someone mixes a 32-bit type with a vm_flags_t.  Any
> > > thoughts on this?
> > > 
> > > (Maybe that's what __nocast does, but Documentation/sparse.txt doesn't
> > > describe it)
> > 
> > Use __bitwise for that - check how gfp_t is handled.
> 
> So what does __nocast do?

Not much...  Basically, extending conversions.  __nocast int can be
freely mixed with int - no complaints will be given.

As far as I'm concerned, it's deprecated - it's weaker than __bitwise and
doesn't have particulary useful semantics.  For this kind of stuff (flags)
__bitwise is definitely better - that's what it had been implemented for.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]