On Wed, 2012-03-21 at 09:12 -0500, Christoph Lameter wrote: > How about this instead? > > Subject: workqueues: Use new kmem cache to get aligned memory for workqueues > > The workqueue logic currently improvises by doing a kmalloc allocation and > then aligning the object. Create a slab cache for that purpose with the > proper alignment instead. > > Cleans up the code and makes things much simpler. No need anymore to carry > an additional pointer to the beginning of the kmalloc object. > > Signed-off-by: Christoph Lameter <cl@xxxxxxxxx> Creating a dedicated cache for few objects ? Thats a lot of overhead, at least for SLAB (no merges of caches) By the way network stack also wants to align struct net_device (in function alloc_netdev_mqs(), and uses a custom code. In this case, as the size of net_device is not constant, we use standard kzalloc(). No idea why NETDEV_ALIGN is 32 ... Oh well, some old constant instead of L1_CACHE_BYTES ... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>