On Sun 13-11-22 17:28:55, Christoph Hellwig wrote:
> ->writepage is a very inefficient method to write back data, and only
> used through write_cache_pages or a a fallback when no ->migrate_folio
> method is present.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good! Feel free to add:
Acked-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/ext2/inode.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 918ab2f9e4c05..3b2e3e1e0fa25 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -869,11 +869,6 @@ int ext2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
> return ret;
> }
>
> -static int ext2_writepage(struct page *page, struct writeback_control *wbc)
> -{
> - return block_write_full_page(page, ext2_get_block, wbc);
> -}
> -
> static int ext2_read_folio(struct file *file, struct folio *folio)
> {
> return mpage_read_folio(folio, ext2_get_block);
> @@ -948,7 +943,6 @@ const struct address_space_operations ext2_aops = {
> .invalidate_folio = block_invalidate_folio,
> .read_folio = ext2_read_folio,
> .readahead = ext2_readahead,
> - .writepage = ext2_writepage,
> .write_begin = ext2_write_begin,
> .write_end = ext2_write_end,
> .bmap = ext2_bmap,
> --
> 2.30.2
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
