On (22/11/11 09:09), Minchan Kim wrote: > > [..] > > OK. Any reason why we don't want u32? I thought that > > s16/u16/s32/u32/etc. is the new normal. > > Oh, I didn't know the new normal. > > # ag u32 mm/ | wc -l > 65 > > Then, I'd like to use int to be consistent with others. OK. > > > Let's just use int instead of u32 > > > > > > Why do you need num_pages argument instead of using 1UL << ZS_DEFAULT_PAGE_ORDER? > > > It looks like static value. > > > > It is static right now, but in the a couple of patches it'll change to > > dynamic. > > Then, plase have the change in the patch you will use to review easier. OK.
