On (22/11/02 13:20), Minchan Kim wrote: > On Tue, Oct 18, 2022 at 01:55:27PM +0900, Sergey Senozhatsky wrote: > > We will use non-WB variant in ZRAM page recompression path. > > > > Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > > --- > > drivers/block/zram/zram_drv.c | 73 ++++++++++++++++++++++++----------- > > 1 file changed, 50 insertions(+), 23 deletions(-) > > > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > > index a8ef3c0c3dae..94c62d7ea818 100644 > > --- a/drivers/block/zram/zram_drv.c > > +++ b/drivers/block/zram/zram_drv.c > > @@ -1314,8 +1314,30 @@ static void zram_free_page(struct zram *zram, size_t index) > > ~(1UL << ZRAM_LOCK | 1UL << ZRAM_UNDER_WB)); > > } > > > > -static int __zram_bvec_read(struct zram *zram, struct page *page, u32 index, > > - struct bio *bio, bool partial_io) > > +/* > > + * Reads a page from the writeback devices. Corresponding ZRAM slot > > + * should be unlocked. > > + */ > > +static int zram_read_from_writeback(struct zram *zram, struct page *page, > > How about zram_read_from_bdev? As far as I can see, we already have that one, so that name is already taken. We have read_from_bdev, read_from_bdev_sync, read_from_bdev_async, and probably some more.
