On Oct 30, 2022, at 2:30 PM, Peter Xu <peterx@xxxxxxxxxx> wrote: > + /* With vma lock held, safe without RCU */ > src_pte = huge_pte_offset(src, addr, sz); Just another option to consider: you can create an inline function huge_pte_offset_locked_mm(), which would do the lockdep_assert_held_*(). I personally would prefer it, since it would clarify exactly the lock you care about and "make the code document itself”.
