On Mon, Oct 31, 2022 at 2:36 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > (c) move it to clean_and_free_pages_and_swap_cache() that actually
> > does the page_zap_pte_rmap() now.
>
> I'm leaning towards (c); simply because the error case is so terrifying
> I feel we should check for it (and I do have vague memories of us
> actually hitting something like this in the very distant past).
Ok. At that point we no longer have the pte or the virtual address, so
it's not goign to be exactly the same debug output.
But I think it ends up being fairly natural to do
VM_WARN_ON_ONCE_PAGE(page_mapcount(page) < 0, page);
instead, and I've fixed that last patch up to do that.
Linus
