Hi Chritoph, > On Oct 17, 2022, at 12:26 AM, Christoph Hellwig <hch@xxxxxx> wrote: > > On Fri, Oct 07, 2022 at 04:43:11PM -0700, Song Liu wrote: >> Changes RFC v1 => RFC v2: >> 1. Major rewrite of the logic of vmalloc_exec and vfree_exec. They now >> work fine with BPF programs (patch 1, 2, 4). But module side (patch 3) >> still need some work. > > Can you please move the changelog under the description of WTF the > series actually does like the normal kernel process? Explaining the > changes from a previous version before you even describe what the series > does is completely incoherent. Will fix in the next version. > >> This set is a prototype that allows dynamic kernel text (modules, bpf >> programs, various trampolines, etc.) to share huge pages. The idea is >> similar to Peter's suggestion in [1]. Please refer to each patch for >> more detais. > > Well, nothing explains what the method is to avoid having memory > that is mapped writable and executable at the same time, which really > could use some explanation here (and in the main patch as well). Thanks for the feedback. I will add this. Does the code look good to you? I personally think patch 1, 2, 4 could ship with a little more work. Thanks, Song
