Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Lutomirski <luto@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Thu, 13 Oct 2022 20:54:14 -0700
Cc: Jann Horn <jannh@xxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Jorge Merlino <jorge.merlino@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, John Johansen <john.johansen@xxxxxxxxxxxxx>, Paul Moore <paul@xxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, "Serge E. Hallyn" <serge@xxxxxxxxxx>, Stephen Smalley <stephen.smalley.work@xxxxxxxxx>, Eric Paris <eparis@xxxxxxxxxxxxxx>, Richard Haines <richard_c_haines@xxxxxxxxxxxxxx>, Casey Schaufler <casey@xxxxxxxxxxxxxxxx>, Xin Long <lucien.xin@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Todd Kjos <tkjos@xxxxxxxxxx>, Ondrej Mosnacek <omosnace@xxxxxxxxxx>, Prashanth Prahlad <pprahlad@xxxxxxxxxx>, Micah Morton <mortonm@xxxxxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Andrei Vagin <avagin@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, apparmor@xxxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx
In-reply-to: <2032f766-1704-486b-8f24-a670c0b3cb32@app.fastmail.com>
References: <20221006082735.1321612-1-keescook@chromium.org> <20221006082735.1321612-2-keescook@chromium.org> <20221006090506.paqjf537cox7lqrq@wittgenstein> <CAG48ez0sEkmaez9tYqgMXrkREmXZgxC9fdQD3mzF9cGo_=Tfyg@mail.gmail.com> <2032f766-1704-486b-8f24-a670c0b3cb32@app.fastmail.com>

On Thu, Oct 13, 2022 at 08:18:04PM -0700, Andy Lutomirski wrote:
> But seriously, this makes no sense at all.  It should not be possible to exec a program and then, without ptrace, change its cwd out from under it.  Do we really need to preserve this behavior?

Yup, already abandoned:
https://lore.kernel.org/lkml/202210061301.207A20C8E5@keescook/

-- 
Kees Cook

References:
- [PATCH 0/2] fs/exec: Explicitly unshare fs_struct on exec
  - From: Kees Cook
- [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
  - From: Kees Cook
- Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
  - From: Christian Brauner
- Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
  - From: Jann Horn
- Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
  - From: Andy Lutomirski

Prev by Date: Re: [RFC v2 3/4] modules, x86: use vmalloc_exec for module core
Next by Date: Re: [PATCH v1] kernel/module: allocate module vmap space after making sure the module is unique
Previous by thread: Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
Next by thread: Re: [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]