On Fri, Oct 07, 2022 at 10:07:04AM +0900, Naoya Horiguchi wrote: > From: Naoya Horiguchi <naoya.horiguchi@xxxxxxx> > > These interfaces will be used by drivers/base/memory.c by later patch, so as a > preparatory work move them to more common header file visible to the file. > > Signed-off-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx> > Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> > --- > ChangeLog v3 -> v6: > - remove static in definition of num_poisoned_pages_inc() to fix build error. > > ChangeLog v2 -> v3: > - added declaration of num_poisoned_pages_inc() in #ifdef CONFIG_MEMORY_FAILURE > --- > arch/parisc/kernel/pdt.c | 3 +-- > include/linux/mm.h | 5 +++++ > include/linux/swapops.h | 24 ++---------------------- > mm/memory-failure.c | 10 ++++++++++ > 4 files changed, 18 insertions(+), 24 deletions(-) > > diff --git a/arch/parisc/kernel/pdt.c b/arch/parisc/kernel/pdt.c > index e391b175f5ec..fdc880e2575a 100644 > --- a/arch/parisc/kernel/pdt.c > +++ b/arch/parisc/kernel/pdt.c > @@ -18,8 +18,7 @@ > #include <linux/kthread.h> > #include <linux/initrd.h> > #include <linux/pgtable.h> > -#include <linux/swap.h> > -#include <linux/swapops.h> > +#include <linux/mm.h> I am probably missing something. num_poisoned_pages_* functions are in swapops.h, but why are you removing swap.h as well? Also, reading the changelog it sounded like both functions would be in mm.h, but actually only the _inc part is. The rest looks good to me. -- Oscar Salvador SUSE Labs
