On Tue, 13 Mar 2012 12:37:06 +0530
"Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote:
> +static int mem_cgroup_hugetlb_usage(struct mem_cgroup *memcg)
> +{
> + int idx;
> + for (idx = 0; idx < hugetlb_max_hstate; idx++) {
> + if (memcg->hugepage[idx].usage > 0)
> + return memcg->hugepage[idx].usage;
> + }
> + return 0;
> +}
Please document the function? Had you done this, I might have been
able to work out why the function bales out on the first used hugepage
size, but I can't :(
This could have used for_each_hstate(), had that macro been better
designed (or updated).
Upon return this function coerces an unsigned long long into an "int".
We decided last week that more than 2^32 hugepages was not
inconceivable, so I guess that's a bug.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>