On Wed, Oct 5, 2022 at 7:44 AM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Tue, Oct 04, 2022 at 03:04:23PM -0700, Axel Rasmussen wrote: > > We should also update the examples / help text near the top of the > > file, since we're changing what arguments this accepts. > > Definitely, I missed that. > > > > > It might also be better to squash the changes to test arguments in > > run_vmtests.sh into each patch, so if we're bisecting we'll have a > > matching / working test + run_vmtests.sh combo at each commit. > > I can do that, but may not be required - note that I did the first three > patches just to make sure they're still compatible with the old cmdlines, > by ignoring the extra params. Ah! In that case, forget it. :) > > [...] > > > This is a nice simplification! Thanks for doing it. Besides the > > comments above, the rest of the code here looks correct to me. Feel > > free to take: > > > > Reviewed-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx> > > Thanks! > > -- > Peter Xu >
