On Oct 3, 2022, at 8:56 AM, Peter Xu <peterx@xxxxxxxxxx> wrote: > > + */ > + if (hugetlb_pte_stable(h, mm, ptep, old_pte)) > + ret = hugetlb_handle_userfault( > + vma, mapping, idx, flags, haddr, > + address, VM_UFFD_MISSING); > + else > + /* Retry the fault */ > + ret = 0; Might be unrelated, but at least for the sake of consistency if not potential GUP issues, don’t you want to return VM_FAULT_RETRY ?
