Sorry for replying late. On Wed, Sep 28, 2022 at 04:03:19PM +0200, David Hildenbrand wrote: > On 27.09.22 21:53, Chih-En Lin wrote: > > On Tue, Sep 27, 2022 at 06:38:05PM +0000, Nadav Amit wrote: > > > I only skimmed the patches that you sent. The last couple of patches seem a > > > bit rough and dirty, so I am sorry to say that I skipped them (too many > > > “TODO” and “XXX” for my taste). > > > > > > I am sure other will have better feedback than me. I understand there is a > > > tradeoff and that this mechanism is mostly for high performance > > > snapshotting/forking. It would be beneficial to see whether this mechanism > > > can somehow be combined with existing ones (mshare?). > > > > Still thanks for your feedback. :) > > I'm looking at the PTE refcount and mshare patches. And, maybe it can > > combine with them in the future. > > > > > The code itself can be improved. I found the reasoning about synchronization > > > and TLB flushes and synchronizations to be lacking, and the code to seem > > > potentially incorrect. Better comments would help, even if the code is > > > correct. > > > > > > There are additional general questions. For instance, when sharing a > > > page-table, do you properly update the refcount/mapcount of the mapped > > > pages? And are there any possible interactions with THP? > > > > Since access to those mapped pages will cost a lot of time, and this > > will make fork() even have more overhead. It will not update the > > refcount/mapcount of the mapped pages. > > Oh no. > > So we'd have pages logically mapped into two processes (two page table > structures), but the refcount/mapcount/PageAnonExclusive would not reflect > that? > > Honestly, I don't think it is upstream material in that hacky form. No, we > don't need more COW CVEs or more COW over-complications that destabilize the > whole system. > I know setting the write protection is not enough to prove the security safe since the previous COW CVEs are related to it. And, if skipping the accounting to reduce the overhead of fork() is not suitable for upstream , we can change it. But, I think COW to the table can still be an upstream material. Recently the patches, like refcount for the empty user PTE page table pages and mshare for the pages shared between the processes require more PTE entries, showing that the modern system uses a lot of memory for the page table (especially the PTE table). So, I think the method, COW to the table, might reduce the memory usage for the side of the multiple users PTE page table. > IMHO, a relaxed form that focuses on only the memory consumption reduction > could *possibly* be accepted upstream if it's not too invasive or complex. > During fork(), we'd do exactly what we used to do to PTEs (increment > mapcount, refcount, trying to clear PageAnonExclusive, map the page R/O, > duplicate swap entries; all while holding the page table lock), however, > sharing the prepared page table with the child process using COW after we > prepared it. > > Any (most once we want to *optimize* rmap handling) modification attempts > require breaking COW -- copying the page table for the faulting process. But > at that point, the PTEs are already write-protected and properly accounted > (refcount/mapcount/PageAnonExclusive). > > Doing it that way might not require any questionable GUP hacks and swapping, > MMU notifiers etc. "might just work as expected" because the accounting > remains unchanged" -- we simply de-duplicate the page table itself we'd have > after fork and any modification attempts simply replace the mapped copy. Agree. However for GUP hacks, if we want to do the COW to page table, we still need the hacks in this patch (using the COW_PTE_OWN_EXCLUSIVE flag to check whether the PTE table is available or not before we do the COW to the table). Otherwise, it will be more complicated since it might need to handle situations like while preparing the COW work, it just figuring out that it needs to duplicate the whole table and roll back (recover the state and copy it to new table). Hopefully, I'm not wrong here. > But devil is in the detail (page table lock, TLB flushing). Sure, it might be an overhead in the page fault and needs to be handled carefully. ;) > "will make fork() even have more overhead" is not a good excuse for such > complexity/hacks -- sure, it will make your benchmark results look better in > comparison ;) ;);) I think that, even if we do the accounting with the COW page table, it still has a little bit improve. > -- > Thanks, > > David / dhildenb > Thanks, Chih-En Lin
