> -----Original Message----- > From: Luck, Tony <tony.luck@xxxxxxxxx> > Sent: September 27, 2022 4:35 PM > To: Thomas Tai <thomas.tai@xxxxxxxxxx>; dave.hansen@xxxxxxxxxxxxxxx; > jarkko@xxxxxxxxxx; reinette.chatre@xxxxxxxx; naoya.horiguchi@xxxxxxx; > linmiaohe@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; Thomas Tai <thomas.tai@xxxxxxxxxx> > Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory > > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection > > address validation), add a similar code in hwpoison_inject function to > > check if the address is located in SGX Memory. The error will then be > > handled by the arch_memory_failure function in the SGX driver. > > Looks good to me. > > [I wish that Linux hadn't called this "hwpoison_inject()" because there's nothing > hardware related about this injection. But you are just an innocent consumer of > that poor naming choice] > > Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx> Thanks, Tony, for your review. Cheers, Thomas > > -Tony
