Hi Liu, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: arm64-randconfig-r036-20220919 (https://download.01.org/0day-ci/archive/20220920/202209200009.uVNUOZp9-lkp@xxxxxxxxx/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/f147c36bfc42b2f7ee738305544169ddeae003e8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Liu-Shixin/mm-Use-hotplug_memory_notifier-instead-of-register_hotmemory_notifier/20220919-160043 git checkout f147c36bfc42b2f7ee738305544169ddeae003e8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> mm/mmap.c:3749:30: error: expected identifier or '(' if (hotplug_memory_notifier(&reserve_mem_notifier, 0)) ^ >> mm/mmap.c:3749:6: error: use of undeclared identifier 'reserve_mem_notifier_mem_nb' if (hotplug_memory_notifier(&reserve_mem_notifier, 0)) ^ include/linux/memory.h:167:28: note: expanded from macro 'hotplug_memory_notifier' register_memory_notifier(&fn##_mem_nb); \ ^ <scratch space>:58:1: note: expanded from here reserve_mem_notifier_mem_nb ^ 2 errors generated. vim +3749 mm/mmap.c 3746 3747 static int __meminit init_reserve_notifier(void) 3748 { > 3749 if (hotplug_memory_notifier(&reserve_mem_notifier, 0)) -- 0-DAY CI Kernel Test Service https://01.org/lkp