On Tue, Mar 06, 2012 at 09:42:57PM -0800, David Rientjes wrote: > On Wed, 7 Mar 2012, Cong Wang wrote: > > > > Following the example at mm/slub.c, add out-of-memory diagnostics to the > > > SLAB allocator to help on debugging certain OOM conditions. > > > > > > An example print out looks like this: > > > > > > <snip page allocator out-of-memory message> > > > SLAB: Unable to allocate memory on node 0 (gfp=0x11200) > > > cache: bio-0, object size: 192, order: 0 > > > node0: slabs: 3/3, objs: 60/60, free: 0 > > > > > > > Nitpick: > > > > What about "node: 0" instead of "node0: " ? > > > > Good catch, that format would match the output of the slub out-of-memory > messages. > To be honest, I really don't see a big advantage on the nitpick, however, if we want to accurately copycat the slub output here, I can insert a blank space between the word and the digit, like the following: "node #: ..." Rafael -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>