On Sat, Sep 03, 2022 at 07:16:12PM -0700, Dan Williams wrote: > diff --git a/mm/gup.c b/mm/gup.c > index 732825157430..499c46296fda 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -177,8 +177,10 @@ static void gup_put_folio(struct folio *folio, int refs, unsigned int flags) > refs *= GUP_PIN_COUNTING_BIAS; > } > > - if (!put_devmap_managed_page_refs(&folio->page, refs)) > - folio_put_refs(folio, refs); > + folio_put_refs(folio, refs); Can this be made unconditional at this point in the series? Shouldn't something have been changed on the get ref side? Jason