Hi Kautuk, On Mon, Mar 05, 2012 at 09:18:25AM -0500, Kautuk Consul wrote: > The loop in __alloc_pages_high_priority() seems to be checking for > (!page) and (gfp_mask & __GFP_NOFAIL) multiple times. > > In fact, we don't really need to check (gfp_mask & __GFP_NOFAIL) > for every iteration of the loop as the gfp_mask remains constant. > > Slightly improve the logic in __alloc_pages_high_priority() to > eliminate these multiple condition checks. Thansk for your effort. Surely we don't need mutliple condition check but it's not fast-path and not a problem about readability. So I don't want to increase text size unnecessary if it doesn't have a benefit. barrios@barrios:~/linux-2.6$ size mm/page_alloc.o text data bss dec hex filename 32772 1307 576 34655 875f mm/page_alloc.o barrios@barrios:~/linux-2.6$ size mm/page_alloc.o.your_patch text data bss dec hex filename 32804 1307 576 34687 877f mm/page_alloc.o.patch -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>