On Fri, 2 Sep 2022 20:45:57 +0100 "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> wrote:
> A lot of comments mention pages when they should say folios.
> Fix them up.
I tweaked this for some mglru changes.
--- a/mm/vmscan.c~mm-vmscan-fix-a-lot-of-comments-vs-mglru
+++ a/mm/vmscan.c
@@ -3643,7 +3643,7 @@ static int folio_update_gen(struct folio
do {
/* lru_gen_del_folio() has isolated this page? */
if (!(old_flags & LRU_GEN_MASK)) {
- /* for shrink_page_list() */
+ /* for shrink_folio_list() */
new_flags = old_flags | BIT(PG_referenced);
continue;
}
@@ -4571,7 +4571,7 @@ static void lru_gen_age_node(struct pgli
}
/*
- * This function exploits spatial locality when shrink_page_list() walks the
+ * This function exploits spatial locality when shrink_folio_list() walks the
* rmap. It scans the adjacent PTEs of a young PTE and promotes hot pages. If
* the scan was done cacheline efficiently, it adds the PMD entry pointing to
* the PTE table to the Bloom filter. This forms a feedback loop between the
@@ -4790,7 +4790,7 @@ static bool isolate_folio(struct lruvec
if (!folio_test_referenced(folio))
set_mask_bits(&folio->flags, LRU_REFS_MASK | LRU_REFS_FLAGS, 0);
- /* for shrink_page_list() */
+ /* for shrink_folio_list() */
folio_clear_reclaim(folio);
folio_clear_referenced(folio);
@@ -4993,7 +4993,7 @@ static int evict_folios(struct lruvec *l
if (list_empty(&list))
return scanned;
- reclaimed = shrink_page_list(&list, pgdat, sc, &stat, false);
+ reclaimed = shrink_folio_list(&list, pgdat, sc, &stat, false);
list_for_each_entry(folio, &list, lru) {
/* restore LRU_REFS_FLAGS cleared by isolate_folio() */
@@ -5010,7 +5010,7 @@ static int evict_folios(struct lruvec *l
spin_lock_irq(&lruvec->lru_lock);
- move_pages_to_lru(lruvec, &list);
+ move_folios_to_lru(lruvec, &list);
walk = current->reclaim_state->mm_walk;
if (walk && walk->batched)
_
