On Thu, Sep 1, 2022 at 11:07 AM Peter Xu <peterx@xxxxxxxxxx> wrote: > > On Thu, Sep 01, 2022 at 10:50:48AM -0700, Yang Shi wrote: > > Yeah, because THP collapse does copy the data before clearing pte. If > > we want to remove pmdp_collapse_flush() by just clearing pmd, we > > should clear *AND* flush pte before copying the data IIRC. > > Yes tlb flush is still needed. IIUC the generic pmdp_collapse_flush() will > still be working (with the pte level flushing there) but it should just > start to work for all archs, so potentially we could drop the arch-specific > pmdp_collapse_flush()s, mostly the ppc impl. I'm don't know why powperpc needs to have its specific pmdp_collapse_flush() in the first place, not only the mandatory IPI broadcast, but also the specific implementation of pmd tlb flush. But anyway the IPI broadcast could be removed at least IMO. > > This also reminded me that the s390 version of pmdp_collapse_flush() is a > bit weird, since it doesn't even have the tlb flush there. I feel like > it's broken but I can't really tell whether something I've overlooked. > Worth an eye on. I don't know why. But if s390 doesn't flush tlb in pmdp_collapse_flush(), then there may be data integrity problem since the page is still writable when copying the data because pte is cleared after data copying. Or s390 hardware does flush tlb automatically? > > -- > Peter Xu >
