In shmem_read_mapping_page_gfp() page is unlocked if no error returned,
so the unlocked page has to valid.
To guarantee that validity, when getting page, success result is feed
back to caller only when page is valid.
Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>
---
--- a/mm/shmem.c Sun Mar 4 12:17:42 2012
+++ b/mm/shmem.c Sun Mar 4 12:26:56 2012
@@ -889,13 +889,13 @@ repeat:
goto failed;
}
- if (page || (sgp == SGP_READ && !swap.val)) {
+ if (page) {
/*
* Once we can get the page lock, it must be uptodate:
* if there were an error in reading back from swap,
* the page would not be inserted into the filecache.
*/
- BUG_ON(page && !PageUptodate(page));
+ BUG_ON(!PageUptodate(page));
*pagep = page;
return 0;
}
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>