Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/31/22 16:21, Marco Elver wrote:
> On Wed, 31 Aug 2022 at 16:04, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> wrote:
> 
>> Maybe you can include those functions too?
>>
>> - __kmem_cache_alloc_node
>> - kmalloc_[node_]trace, kmalloc_large[_node]
> 
> This is only required if they are allocator "root" functions when
> entering allocator code (or may be tail called by a allocator "root"
> function). Because get_stack_skipnr() looks for one of the listed
> function prefixes in the whole stack trace.
> 
> The reason __kmem_cache_free() is now required is because it is tail
> called by kfree() which disappears from the stack trace if the
> compiler does tail-call-optimization.

I checked and I have this jmp tail call, yet all test pass here.
But I assume the right commit to amend is
05a1c2e50809 ("mm/sl[au]b: generalize kmalloc subsystem")

Could you Feng maybe verify that that commit is the first that fails the
tests, and parent commit of that is OK? Thanks.






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux