Re: [PATCH] fs/proc/kcore.c: Pass a pointer to virt_addr_valid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 29, 2022 at 5:18 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> On Mon, Aug 29, 2022 at 03:13:17PM +0200, Linus Walleij wrote:

> > The virt_addr_valid() should be passed a pointer, the current
> > code passing a long unsigned int is just exploiting the
> > unintentional polymorphism of these calls being implemented
> > as preprocessor macros.
>
> Why do you think it's unintended polymorphism?  It looks to me
> like polymorphism is absolutely intended.

Intended, maybe.
Desired, no:
https://lore.kernel.org/linux-mm/20220701160004.2ffff4e5ab59a55499f4c736@xxxxxxxxxxxxxxxxxxxx/

Strong typing is nice.

Yours,
Linus Walleij




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux