On Mon, Aug 29, 2022 at 04:32:47PM +0800, Song Chen wrote:
> Hi,
>
>
> 在 2022/8/29 16:24, Mike Rapoport 写道:
> > On Mon, Aug 29, 2022 at 02:39:00PM +0800, Song Chen wrote:
> > > Commit 14d9a675fd0d("mm: Ratelimited mirrored memory related warning
> > > messages") introduced pr_warn_ratelimited in memblock.c, which breaks
> > > tools/test/memblock, below is the message:
> > >
> > > /usr/bin/ld: memblock.o: in function `memblock_find_in_range.constprop.0':
> > > memblock.c:(.text+0x4603): undefined reference to `pr_warn_ratelimited'
> > > /usr/bin/ld: memblock.o: in function `memblock_alloc_range_nid':
> > > memblock.c:(.text+0x786a): undefined reference to `pr_warn_ratelimited'
> > > collect2: error: ld returned 1 exit status
> > >
> > > A fake pr_warn_ratelimited needs to be defined in printk.h like other
> > > prink functions.
> >
> > This is fixed by commit 0a7e91528202 ("memblock tests: fix compilation errors")
>
> Is there a commit taking care of 902c2d91582c(mirrored_kernelcore) ? it
> brakes memblock test too. If not, i have fixed it and will send a patch
> soon.
Yes, the same commit that fixed pr_warn_ratelimited() issue.
Please work with recent version of the kernel tree to avoid work
duplication.
> Song
>
--
Sincerely yours,
Mike.
