On 8/24/22 15:04, Hyeonggon Yoo wrote: > On Tue, Aug 23, 2022 at 07:04:00PM +0200, Vlastimil Babka wrote: >> The PREEMPT_RT specific disabling of irqs in __cmpxchg_double_slab() >> (through slab_[un]lock()) is unnecessary as bit_spin_lock() disables >> preemption and that's sufficient on RT where interrupts are threaded. >> >> That means we no longer need the slab_[un]lock() wrappers, so delete >> them and rename the current __slab_[un]lock() to slab_[un]lock(). >> >> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx> >> Acked-by: David Rientjes <rientjes@xxxxxxxxxx> >> - >> /* >> * Interrupts must be disabled (for the fallback code to work right), typically >> - * by an _irqsave() lock variant. Except on PREEMPT_RT where locks are different >> - * so we disable interrupts as part of slab_[un]lock(). >> + * by an _irqsave() lock variant. Except on PREEMPT_RT where these variants do >> + * not actually disable interrupts. On the other hand the migrate_disable() > > You mean preempt_disable()? I did, thanks for catching it. > migrate_disable() will not be enough. > >> -- >> 2.37.2 > > Otherwise looks good to me. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> Thanks!
