> Please have a think about all of this and see if you can demonstrate > how the iput() here is guaranteed safe. There are already several __iget()/iput() calls inside fs-writeback.c. The existing iput() calls already demonstrate its safety? Basically the flusher works in this way - the dirty inode list i_wb_list does not reference count the inode at all - the flusher thread does something analog to igrab() and set I_SYNC before going off to writeout the inode - evice() will wait for completion of I_SYNC Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>