Re: [PATCH 1/6] mm: pagewalk: make error checks more obvious

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, 23. August 2022, 11:16:42 CEST schrieb Dan Carpenter:
> Hi Rolf,
> 
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:   
> https://github.com/intel-lab-lkp/linux/commits/Rolf-Eike-Beer/Minor-improve
> ments-for-pagewalk-code/20220822-214107 base:  
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> config: x86_64-randconfig-m001
> (https://download.01.org/0day-ci/archive/20220823/202208231649.7QKavhA3-lkp
> @intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> smatch warnings:
> mm/pagewalk.c:248 walk_p4d_range() error: uninitialized symbol 'err'.
> mm/pagewalk.c:287 walk_pgd_range() error: uninitialized symbol 'err'.
> mm/pagewalk.c:324 walk_hugetlb_range() error: uninitialized symbol 'err'.
> 
> vim +/err +248 mm/pagewalk.c

[...]

> Same.  Although this seems more like a real bug.

They all are. I wonder how they got lost and why this never showed up during 
my tests, but still.

Andrew, do you want me to resend the series with the fixes squashed in or add a 
v7?

Eike
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux