On 08/20/22 at 11:54pm, Christoph Hellwig wrote: > > -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot); > > +void __iomem * > > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val); > > It seems a bit odd to do this in two steps vs just doing the entire > change in the first patch. Any good reason for that? I will merge patch 1~2 or 1~3 into patch 1. Earlier, I wrote the reason as below paragraph in cover letter of v1 post. Now it seems not so hard to tell and understand. ==== For patch 1~3, I don't merge them because I made them in different rounds of changing. And splitting them makes me easily describe the intention and make review easier. I can merge them after v1 reviewing if anyone thinks they should be merged. ====