Hi Xin, On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao <xhao@xxxxxxxxxxxxxxxxx> wrote: > The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of > 'damon_addr_range', so, there no need to redefine it, just use struct of > 'damon_addr_range' instead. Reducing code is always good, thanks. However, I think the type of the 'start' and 'end' fields of 'struct damon_addr_range' might be changed in a future. It's very unlikely, though. Also, we might add some more fields to the struct in a future. After all, the purpose of 'struct damon_addr_range' is not saving the 'start' and 'end' fields of 'struct resource'. I'd like to avoid making any possible dependency here, sorry. Thanks, SJ [...]
