> -----Original Message----- > From: David Hildenbrand <david@xxxxxxxxxx> > Sent: Monday, August 15, 2022 00:31 > To: Wang, Haiyue <haiyue.wang@xxxxxxxxx>; linux-mm@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Cc: akpm@xxxxxxxxxxxxxxxxxxxx; linmiaohe@xxxxxxxxxx; Huang, Ying <ying.huang@xxxxxxxxx>; > songmuchun@xxxxxxxxxxxxx; naoya.horiguchi@xxxxxxxxx; alex.sierra@xxxxxxx > Subject: Re: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page > > On 14.08.22 16:05, Haiyue Wang wrote: > > The commit > > 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages") > > doesn't handle the follow_page with flag FOLL_GET correctly, this will > > do get_page on page, it shouldn't just return directly without put_page. > > > > So revert the related fix to prepare for clean patch to handle Non-LRU > > pages returned by follow_page. > > What? Why? > Just as the cover letter said, for applying the PATCH 2/3 can be applied on Linux-5.19 branch directly. I will drop this kind of fix, and fix the issue directly in v3. > Just fix it. > > -- > Thanks, > > David / dhildenb