On Tue, Feb 28, 2012 at 5:34 AM, Glauber Costa <glommer@xxxxxxxxxxxxx> wrote: > On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: >> >> This config option dictates whether or not kernel memory in the >> root cgroup should be accounted. >> >> This may be useful in an environment where everything is supposed to be >> in a cgroup and accounted for. Large amounts of kernel memory in the >> root cgroup would indicate problems with memory isolation or accounting. > > > I don't like accounting this stuff to the root memory cgroup. This causes > overhead for everybody, including people who couldn't care less about memcg. > > If it were up to me, we would simply not account it, and end of story. > > However, if this is terribly important for you, I think you need to at > least make it possible to enable it at runtime, and default it to disabled. Yes, that is why I made it a config option. If the config option is disabled, that memory does not get accounted at all. Making it configurable at runtime is not ideal, because we would prefer slab memory that was allocated before cgroups are created to still be counted toward root. -- Suleiman -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>