Thanks Andrew!! On 8/11/2022 3:01 AM, Andrew Morton wrote: > On Wed, 10 Aug 2022 22:58:05 +0530 Charan Teja Kalla <quic_charante@xxxxxxxxxxx> wrote: > >> Currently only 12 characters of the cma name is being used as the debug >> directories where as the cma name can be of length CMA_MAX_NAME(=64) >> characters. One side problem with this is having 2 cma's with first >> common 12 characters would end up in trying to create directories with >> same name and fails with -EEXIST thus can limit cma debug functionality. > > I guess so. There might be back-compatibility issues, but it's > debugfs... > > >> Also drop 'cma-' prefix for the cma debug directories as they are >> clearly evident that they are for cma debug through creating them in >> /sys/kernel/debug/cma/ path. > > I guess so. But please run `grep -r cma- Documentation' I see the Documentation/admin-guide/mm/cma_debugfs.rst is not upto date. Commit f318dd083c81 ("cma: Store a name in the cma structure") moved the cma names from int to strings but no update to this document. Will fix the Documentation part in V2. >